Skip to content

WIP - Plugin system#1237

Closed
sdispater wants to merge 1 commit intodevelopfrom
plugin-system
Closed

WIP - Plugin system#1237
sdispater wants to merge 1 commit intodevelopfrom
plugin-system

Conversation

@sdispater
Copy link
Copy Markdown
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This is a WIP implementation of the previously mentionned plugin system. It is not fully functional at the moment (and does not work at all with the recommended installer). The implementation will likely change as I make progress on it. Nonetheless, the general idea of what it will look like is here.

Note that it will likely not make it to the 1.0.0 release.

@kapilt
Copy link
Copy Markdown

kapilt commented Feb 13, 2020

one comment, its a little unclear if this is present already, but I was wondering about ensuring that builtin commands can't be overridden to avoid inconsistencies in user experience.

@keattang
Copy link
Copy Markdown

Eagerly awaiting this! Any ideas when it may get released?

@danieleades
Copy link
Copy Markdown
Contributor

This seems like a really powerful and flexible plugin system. I'm looking to seeing how people extend poetry's functionality using this framework to make it a powerful test runner and CI tool.

I also wonder if this is not quite heavy weight for the many people who are looking for a simple hook. Consider Yarn's hook system where scripts definesdin the project manifest with 'special' names are invoked for specific methods. For example if you have a script defined called 'prepublish', that script will be called before publishing.

How can I use this plugin to create a simple hook at a specific point? My use-case, for example, is to run code-generation on some proto files. Creating an entire package to run a one line script seems excessive.

@sdispater
Copy link
Copy Markdown
Member Author

Closing in favor of #3733

@sdispater sdispater closed this Mar 9, 2021
@sdispater sdispater deleted the plugin-system branch March 9, 2021 20:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/plugin-api Related to plugins/plugin API kind/feature Feature requests/implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants