remove duplicate coverage for show --group command unit tests#10524
Merged
radoering merged 1 commit intoAug 30, 2025
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSimplified show command tests by removing explicit group filtering test functions and relying on the existing parametrized test to cover --without, --only, and optional group scenarios. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Aearsears
marked this pull request as ready for review
August 27, 2025 22:22
radoering
approved these changes
Aug 30, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Relates-to: #10487 and #3155. While working on #10487, I noticed there was some duplicate test coverage for the
showcommand. This PR removes the duplicated test coverage. Below describes the removed tests and which test covers it.test_show_non_dev_with_basic_installed_packagesThis test has a
devgroup package and tests for packages--without dev. This is captured by the parametrized testtest_show_basic_with_group_options[--without test]test_show_with_group_onlyThis test has a
devgroup package and we only want to show--only dev. This is captured by the parametrized testtest_show_basic_with_group_options[--only time]test_show_with_optional_groupThis test has a
devoptional group package and we test output without specifying this optional group and with--with dev. This is captured by the parametrized testtest_show_basic_with_group_options[--with time]andtest_show_basic_with_group_options[].timeis the optional group setup in the_configure_project_with_groupshelper function.Summary by Sourcery
Remove redundant unit tests for the "show" command’s group filtering options and rely on existing parametrized tests for coverage
Enhancements:
Tests: