Skip to content

remove duplicate coverage for show --group command unit tests#10524

Merged
radoering merged 1 commit into
python-poetry:mainfrom
Aearsears:remove-duplicate-show-tests
Aug 30, 2025
Merged

remove duplicate coverage for show --group command unit tests#10524
radoering merged 1 commit into
python-poetry:mainfrom
Aearsears:remove-duplicate-show-tests

Conversation

@Aearsears

@Aearsears Aearsears commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Pull Request Check List

Relates-to: #10487 and #3155. While working on #10487, I noticed there was some duplicate test coverage for the show command. This PR removes the duplicated test coverage. Below describes the removed tests and which test covers it.

test_show_non_dev_with_basic_installed_packages
This test has a dev group package and tests for packages --without dev. This is captured by the parametrized test test_show_basic_with_group_options[--without test]

test_show_with_group_only
This test has a dev group package and we only want to show --only dev. This is captured by the parametrized test test_show_basic_with_group_options[--only time]

test_show_with_optional_group
This test has a dev optional group package and we test output without specifying this optional group and with --with dev. This is captured by the parametrized test test_show_basic_with_group_options[--with time] and test_show_basic_with_group_options[]. time is the optional group setup in the _configure_project_with_groups helper function.

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Remove redundant unit tests for the "show" command’s group filtering options and rely on existing parametrized tests for coverage

Enhancements:

  • Consolidate show command tests by eliminating duplicate scenarios already handled by test_show_basic_with_group_options

Tests:

  • Remove test_show_non_dev_with_basic_installed_packages, test_show_with_group_only, and test_show_with_optional_group as their coverage is provided by parametrized tests

@sourcery-ai

sourcery-ai Bot commented Aug 27, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Simplified show command tests by removing explicit group filtering test functions and relying on the existing parametrized test to cover --without, --only, and optional group scenarios.

File-Level Changes

Change Details Files
Removed duplicate group filtering tests for the show command
  • Deleted test_show_non_dev_with_basic_installed_packages (--without dev)
  • Deleted test_show_with_group_only (--only dev)
  • Deleted test_show_with_optional_group (--with dev and default)
tests/console/commands/test_show.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Aearsears
Aearsears marked this pull request as ready for review August 27, 2025 22:22

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering
radoering merged commit 79c0a6e into python-poetry:main Aug 30, 2025
53 checks passed
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants