Skip to content

tests: disable keyring instead of setting a fail keyring#304

Merged
abn merged 1 commit into
python-poetry:mainfrom
radoering:disable-keyring
Nov 17, 2024
Merged

tests: disable keyring instead of setting a fail keyring#304
abn merged 1 commit into
python-poetry:mainfrom
radoering:disable-keyring

Conversation

@radoering

Copy link
Copy Markdown
Member

@radoering
radoering requested a review from a team November 6, 2024 16:59
@sonarqubecloud

Copy link
Copy Markdown

@abn

abn commented Nov 17, 2024

Copy link
Copy Markdown
Member

Do we have coverage elsewhere for failing keyring backends?

@radoering

Copy link
Copy Markdown
Member Author

This is poetry-plugin-export. And this is the default config fixture for all tests. I do not think that we need coverage for failing keyring backends here. I assume we just want to deactivate keyring for the tests because as we all know it can cause trouble.

I am only doing this change because we should not import keyring without declaring it as dev dependency.

@abn
abn merged commit a39bc5f into python-poetry:main Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants