Skip to content

Add authors to required fields#99

Closed
abitrolly wants to merge 4 commits into
python-poetry:mainfrom
abitrolly:patch-1
Closed

Add authors to required fields#99
abitrolly wants to merge 4 commits into
python-poetry:mainfrom
abitrolly:patch-1

Conversation

@abitrolly

@abitrolly abitrolly commented Oct 9, 2020

Copy link
Copy Markdown

Relates-to: python-poetry/poetry#407
Relates-to: python-poetry/poetry#3155

UPDATE: I see this is a duplicate of #37 Let me add tests to it.

@abitrolly

Copy link
Copy Markdown
Author

Unable to run tests, because poetry install fails. Looking into this.

$ poetry install
The lock file might not be compatible with the current version of Poetry.
Upgrade Poetry to ensure the lock file is read properly or, alternatively, regenerate the lock file with the `poetry lock` command.
Installing dependencies from lock file

[RecursionError]
maximum recursion depth exceeded while calling a Python object

@abitrolly
abitrolly force-pushed the patch-1 branch 2 times, most recently from 6797a10 to 3604970 Compare October 10, 2020 17:36
@abitrolly

Copy link
Copy Markdown
Author

@python-poetry/triage this is ready for review.

@finswimmer
finswimmer requested a review from a team October 11, 2020 06:24
@abitrolly

Copy link
Copy Markdown
Author

This is hacktoberfest related PR. Any chance to get it merged before the deadline? Pretty please. :D

@luni3359

luni3359 commented Sep 26, 2021

Copy link
Copy Markdown

While this is now in the documentation, poetry check still incorrectly marks the pyproject.toml file as correct even if the authors key is missing.

@abitrolly

abitrolly commented Sep 27, 2021

Copy link
Copy Markdown
Author

The indentation in 44167a5 made this PR unmergeable. I am looking for a way to fix this.

Ryan Delaney and others added 4 commits September 27, 2021 13:56
Before this change, a pyproject.toml file without an "authors" field
would throw an unhandled `NonExistentKey` exception. Now it will be
returned as a config validation error, as with the "name", "version",
and "description" fields.
@abitrolly

Copy link
Copy Markdown
Author

Rebased and ready for review again.

@Secrus

Secrus commented Aug 22, 2022

Copy link
Copy Markdown
Member

Superseeded by #437

@Secrus Secrus closed this Aug 22, 2022
@abitrolly

Copy link
Copy Markdown
Author

Stealing PRs is unfair! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants