pep440: support upper bound post/local release comparisons#157
Merged
Conversation
abn
marked this pull request as ready for review
April 2, 2021 15:09
This change ensures that post and local releases are taken into consideration when checking if version range allows a post release local build release at upper and lower bounds. The following conditions now hold for upper bound checks. - `<=3.0.0` allows `3.0.0+local.1`, `3.0.0-1` - `<=3.0.0+local.1` disallows `3.0.0+local.2`, allows `3.0.0-1` - `<=3.0.0-1` allows `3.0.0+local.1`, `3.0.0` Lower bound checks require no modification and works due to the implicit version comparison of `poetry.core.pep440.PEP440Version`.
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that post and local releases are taken into
consideration when checking if version range allows a post release
local build release at upper and lower bounds.
The following conditions now hold for upper bound checks.
<=3.0.0allows3.0.0+local.1,3.0.0-1<=3.0.0+local.1disallows3.0.0+local.2, allows3.0.0-1<=3.0.0-1allows3.0.0+local.1,3.0.0Lower bound checks require no modification and works due to the
implicit version comparison of
poetry.core.pep440.PEP440Version.Note: Majority of the changes here are test coverage.