Rebased version of "Implementation of equality for the Settings class"#465
Merged
alexwlchan merged 2 commits intomasterfrom Feb 13, 2017
Merged
Rebased version of "Implementation of equality for the Settings class"#465alexwlchan merged 2 commits intomasterfrom
alexwlchan merged 2 commits intomasterfrom
Conversation
Lukasa
approved these changes
Feb 13, 2017
Member
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
LGTM.
@alexwlchan, given that you're now maintaining a branch, want to go ahead and add a changelog entry for this (it's a backward-compatible API change) before I merge?
Contributor
Author
Done. |
Member
|
@alexwlchan ❤️ You're my hero. When the builds go green I'll merge. |
Contributor
Author
|
🍏 |
This was referenced Feb 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #464, presented as a single commit.
Trying the merge/rebase locally was causing sufficiently many issues/merge conflicts for Git that I just did it by hand rather than trust GitHub to get it right. Diff is now identical to the previous PR, save one typo which I fixed. (Still had one reference to
anInstancefloating around; I corrected toan_instance.)