pre-commit: update flake8 3.7.7 -> 3.8.1#7121
Conversation
New errors:
testing/test_setupplan.py:104:15: E741 ambiguous variable name 'l'
testing/test_setupplan.py:107:15: E741 ambiguous variable name 'l'
extra/get_issues.py:48:29: E741 ambiguous variable name 'l'
testing/test_error_diffs.py:270:32: E741 ambiguous variable name 'l'
Not so sure about it but easier to just fix.
But more importantly, is a large amount of typing-related issues there
were fixed which necessitated noqa's which can now be removed.
Mostly I wanted to remove uses of `noqa`. In Python 3 the two are the same.
bluetech
changed the title
|
I updated to the released flake8 version, so this is ready now. |
| try: | ||
| actual = np.asarray(actual) | ||
| except: # noqa | ||
| except BaseException: |
There was a problem hiding this comment.
as followup, i wonder if Exception would be a better limit
There was a problem hiding this comment.
np.asarray seems to except any and all inputs, so I doubt it can even raise at all, but BaseException is definitely inappropriate here. I'll just go ahead and change it to Exception in this PR, I think it's safe to do.
| try: | ||
| result = func() | ||
| except: # noqa | ||
| except BaseException: |
There was a problem hiding this comment.
if we catch it here, we can as a followup clean up the exceptioninfo usage, and bind a variable name + use isintstance
There was a problem hiding this comment.
clean up the exceptioninfo usage
It would be be nice to have a ExceptionInfo.from_exception(e) which does ExceptionInfo.from_exc_info((type(e), e, e.__traceback__)), but since it doesn't exist yet the current code seems a bit cleaner.
There was a problem hiding this comment.
all we use it for is a reraise, thats why i think we do not need the actual object at all
except ... as e:
if reraise is not None and isinstance(e, reraise):
raise
There was a problem hiding this comment.
oh eh im wrong, its necessary just below
however on pytohn3 we should deprecate from_current, and add a from_exception method, as that old style 3-tuple is no longer sensible and necessary
definitively something for a followup
i want to see a complete replacement for exceptioninfo mit to long term
I'm not sure if it can even raise at all, but catching BaseException would swallow ctrl-C and such and is definitely inappropriate here.
2 participants
[flake8 3.8.0 is not released yet, only an alpha -- marked WIP until it is released officially.]The new flake8 (or more correctly the pyflakes version it uses) fixes several issues that come up a lot with type annotations, so I'm eager to update so I can stop typing all of those noqa's :)