Fix bug discovered due to the change in implicit-str-concat - #12378
Merged
webknjaz merged 2 commits intoMar 10, 2026
Merged
Conversation
Pierre-Sassoulas
added
type: bug
Pierre-Sassoulas
changed the title
implicit-str-concat and bug discovered due to the changeimplicit-str-concat
Pierre-Sassoulas
marked this pull request as draft
May 27, 2024 21:39
Pierre-Sassoulas
force-pushed
the
fix-implicit-str-concat-and-discovered-bug-due-to-it
branch
from
May 29, 2024 13:33
398df71 to
5f1f3aa
Compare
webknjaz
reviewed
Oct 23, 2024
Pierre-Sassoulas
force-pushed
the
fix-implicit-str-concat-and-discovered-bug-due-to-it
branch
2 times, most recently
from
January 11, 2025 07:43
e744a14 to
a5f5100
Compare
Pierre-Sassoulas
added
the
skip news
Tusenka
approved these changes
Apr 13, 2025
webknjaz
reviewed
Feb 11, 2026
webknjaz
reviewed
Feb 11, 2026
Pierre-Sassoulas
force-pushed
the
fix-implicit-str-concat-and-discovered-bug-due-to-it
branch
from
February 12, 2026 12:27
5be48f4 to
75ef584
Compare
Pierre-Sassoulas
marked this pull request as ready for review
February 12, 2026 12:28
Member
Author
|
@webknjaz here's an easy 1 line review for you 😉 |
webknjaz
approved these changes
Mar 10, 2026
webknjaz
enabled auto-merge
March 10, 2026 20:01
Member
Author
|
Thank you! |
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: Backported as #14282 🤖 @patchback |
patchback Bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
…at-and-discovered-bug-due-to-it Fix bug discovered due to the change in ``implicit-str-concat`` (cherry picked from commit 55560d9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12172 (comment). I must confess I just followed suggestion blindly and don't understand much 😄 Need to retro-engineer a little to understand what's happening.