Proposal: root spec import mode to replace legacy importing and importmode - #10824
Draft
RonnyPfannschmidt wants to merge 3 commits into
Draft
Proposal: root spec import mode to replace legacy importing and importmode#10824RonnyPfannschmidt wants to merge 3 commits into
RonnyPfannschmidt wants to merge 3 commits into
Conversation
RonnyPfannschmidt
force-pushed
the
draft-importmode-rootspec
branch
from
March 20, 2023 15:27
a03a8fa to
c37f550
Compare
Member
Author
|
Note on implementation, This will require py3.9+ importlib_metadata apis for the details on resource An accompanying note to migrate to their apis seems necessary (so that pytest can warn on stale resources as well The best way to register test root namespaces is still unclear |
Member
Author
|
@bluetech i wonder if this proposal/idea could integrate with directory/package collection enhancements/changes in a way that allows migration |
bluetech
reviewed
Jun 6, 2023
| :orphan: | ||
|
|
||
| =================================== | ||
| PROPOSAL: Parametrize with fixtures |
Comment on lines
+16
to
+17
| test module discovery in pytest currently is is pre-pep40 and create pains for users | ||
| by adding anything things to sys.path and creating easy conflicts in sys.modules |
Member
There was a problem hiding this comment.
Suggested change
| test module discovery in pytest currently is is pre-pep40 and create pains for users | |
| by adding anything things to sys.path and creating easy conflicts in sys.modules | |
| Test module discovery in pytest currently is is pre-PEP420 and creates pain for users | |
| by adding things to ``sys.path`` and creating easy conflicts in ``sys.modules``. |
| A new import mode take a definition of import roots. | ||
|
|
||
| a import root is either a folder in the worktree that will no be installed, | ||
| or a folder that will be installed either normally or editable. |
Member
There was a problem hiding this comment.
How is installation done? Like pytest will install to the venv with pip?
Member
Author
There was a problem hiding this comment.
Users Will have to manage install, pytest should never do that part
|
|
||
| In any case pytest will collect the file tree in the working directory. | ||
|
|
||
| If normal install us used and the content of the imported file differs from the working directory, |
Member
There was a problem hiding this comment.
Suggested change
| If normal install us used and the content of the imported file differs from the working directory, | |
| If normal install is used and the content of the imported file differs from the working directory, |
|
... any chance this proposal might happen? (I realize that's probably just asking if anyone is going to take on the work and I"m not here volunteering so... mostly just poking it to see if there is interest) |
Member
Author
|
I have 2 refactoring of horror higher on my priority Lust ans im currently very thin stretched for time on that |
Rename the proposal from importmode_root_spec to import_roots and reposition it as a declarative alternative that replaces --import-mode instead of adding a fourth mode: * update the problem statement for the pytest 8 importlib rework (real module names, sys.modules insertion) and ground it in the modern import system (PEP 420/451/610/660, importlib.metadata) * specify implied roots for simple layouts with a hard failure on ambiguity instead of guessing * specify minimal editable vs real vs stale install classification via PEP 610 direct_url.json, with StaleInstallError on divergence * fix the copy-pasted title and turn the todo notes into a proper test case matrix Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collection targets must map to exactly one root, testpaths entries act as an inference signal for local roots, and conftest files above every root are recorded as an open naming question. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RonnyPfannschmidt
force-pushed
the
draft-importmode-rootspec
branch
from
July 24, 2026 09:38
c37f550 to
e690aff
Compare
RonnyPfannschmidt
added
the
skip news
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr is a starting point for a import-mode that supports modern importing
the key ideas are