Deprecate/drop support for accepting bytes in terminal.write_line

[nicoddemus]

From: #7142 (comment)

[avats-dev]

@nicoddemus Also this one too, can you help out a bit? I think I have to add DeprecationWarning here

pytest/src/_pytest/terminal.py

Lines 424 to 428 in 133e8af

	def write_line(self, line: Union[str, bytes], **markup: bool) -> None:
	if not isinstance(line, str):
	line = str(line, errors="replace")
	self.ensure_newline()
	self._tw.line(line, **markup)

, right?

[nicoddemus]

Hi @avats-dev,

Thanks for the offer!

Generally yes, but the process is a bit more involved:

• Add the warning message in src/_pytest/deprecated.py.
• Add a test in testing/deprecated_test.py.
• Issue the warning in the location you posted.
• Add a CHANGELOG entry style deprecation.
• Add yourself to authors.

I might have forgotten something, but don't hesitate in open the PR, we can discuss last minute changes there. 👍

[avats-dev]

Ok @nicoddemus , thanks for the insights. I'll open a PR soon with the changes. Also, we're deprecating here but we can also drop this as mentioned in the issue, so would that be alright?

[nicoddemus]

... but we can also drop this as mentioned in the issue, so would that be alright?

Our policy is to deprecate it first and only drop it in the next major release, so we really should deprecate it first. 👍