Update linting and pin black (also in CI)#43
Merged
Conversation
Make sure we use this in CI, development environments and pre-commit
Collaborator
Author
|
@ecederstrand, I included your commit here. I wanted to get CI working again. |
Collaborator
Author
|
@MuellerSeb, could you have a look? |
MuellerSeb
reviewed
Apr 27, 2026
Collaborator
MuellerSeb
left a comment
MuellerSeb
left a comment
There was a problem hiding this comment.
Cool! Good point to switch to pyproject.toml.
Why the long line length?
Beside that. I am okay with it.
Fixes license specifiers according to https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files This allows automatic license inspection tools like pip-licenses to correctly categorize this package.
MuellerSeb
reviewed
Apr 27, 2026
MuellerSeb
reviewed
Apr 27, 2026
Collaborator
Author
|
Thanks so much @MuellerSeb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
blackto the latest version (26.3.1), makes sure CI uses that version, and lints the code with that version.It adds a
pyproject.tomlto configureblackand addspre-commitas to the development conda environment.(We should probably migrate
setup.pyandsetup.cfgtopyproject.tomlat some point...)Closes #42