Open
Conversation
Camera endpoints now only return active poses when listing camera details.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 88.07% 88.20% +0.13%
==========================================
Files 51 51
Lines 2147 2154 +7
==========================================
+ Hits 1891 1900 +9
+ Misses 256 254 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n inactive poses - poses.py: list_current_poses now filters active=True (consistent with camera endpoints) - detections.py: reject detection creation on inactive poses with 422 - client test: update expected ValueError message after update_pose signature change
- poses.py: filter active=True in list_current_poses (camera token path) - detections.py: reject detection creation on inactive poses (422) - client test: update expected ValueError message after signature change - migration: guard add_column with table/column existence checks for fresh DB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poses represent camera orientations that can change over time. Previously, all poses (including outdated ones)
were returned when fetching cameras, which cluttered the frontend with stale data. We still need to keep old
poses in the database for historical consistency (linked detections, sequences, etc.), so rather than deleting
them, we introduce an active boolean flag to soft-filter them.