Only include arg_constraints in pytree_data_fields if they are not lazy_propertys.#1929
Merged
fehiepsi merged 1 commit intopyro-ppl:masterfrom Dec 5, 2024
Merged
Conversation
…t `lazy_property`s.
fehiepsi
approved these changes
Dec 5, 2024
Member
fehiepsi
left a comment
There was a problem hiding this comment.
LGTM! Re get_args: it depends on the definition of the method. It might be worth to add a clear description there. Any method with lazy properties might give inconsistent behaviors, not just with get_args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to address #1928 to obtain consistent pytree structures.
On a related note, similar behavior is observed with the
get_argsmethod. I'm not sure what the "correct" behavior should be in this case.