Generic typing for register methods in pkg_resources#4355
Merged
Conversation
Avasam
force-pushed
the
pkg_resources-adapter-types
branch
2 times, most recently
from
8f2a102 to
2c2874d
Compare
Avasam
force-pushed
the
pkg_resources-adapter-types
branch
from
1f63eb9 to
5152bd8
Compare
This was referenced May 23, 2024
Avasam
force-pushed
the
pkg_resources-adapter-types
branch
2 times, most recently
from
75a7ea6 to
70334da
Compare
abravalheri
approved these changes
May 24, 2024
abravalheri
left a comment
abravalheri
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much.
I wonder if this is OK to be merged or if it was surpassed by any other recent PR.
Contributor
Author
|
@abravalheri You can merge! Might get a conflict somewhere, but this wasn't included with another PR. |
abravalheri
force-pushed
the
pkg_resources-adapter-types
branch
from
70334da to
3ce6d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Review and merge after #4246
This is an immediate follow-up but with more precise and complex typing.
works towards step 3.2 of #2345 (comment)
Once this #4391 and #4390 are merged,
pkg_setuptoolswill be on par with TypeshedPull Request Checklist
newsfragments/. (no user facing changes yet until pkg_resources is considered typed)(See documentation for details)