Skip to content

Using vendored distutils._modified directly in build_clib#4233

Closed
Avasam wants to merge 2 commits into
pypa:mainfrom
Avasam:distutils._modified
Closed

Using vendored distutils._modified directly in build_clib#4233
Avasam wants to merge 2 commits into
pypa:mainfrom
Avasam:distutils._modified

Conversation

@Avasam

@Avasam Avasam commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

Noticed here #3979 (comment)

_modified doesn't exist in stdlib (it was added in the vendored distutils). And distutils.dep_util.newer_pairwise_group doesn't exist either. So I don't see why setuptools.modified or .._distutils._modified couldn't always be used directly.

Work towards #2345 by having 1 less untyped import

Pull Request Checklist

  • Changes have tests (existing SETUPTOOLS_USE_DISTUTILS tests should pass)
  • News fragment added in newsfragments/.
    (See documentation for details)

@Avasam

Avasam commented Feb 25, 2024

Copy link
Copy Markdown
Contributor Author

Well this didn't work the way I thought it would.

@Avasam Avasam closed this Feb 25, 2024
@Avasam Avasam deleted the distutils._modified branch May 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant