Skip to content

action: use the most recent python from tool cache to run the GitHub Action#1114

Merged
mayeut merged 5 commits into
pypa:mainfrom
mayeut:action-tool-cache
Jul 14, 2022
Merged

action: use the most recent python from tool cache to run the GitHub Action#1114
mayeut merged 5 commits into
pypa:mainfrom
mayeut:action-tool-cache

Conversation

@mayeut

@mayeut mayeut commented May 22, 2022

Copy link
Copy Markdown
Member

This allows to drop python 3.6 without losing support for ubuntu-18.04 runners c.f. #508.

Blocked on actions/setup-python#411
Blocked on a new release of actions/setup-python
v4.1 has been released.

Comment thread .github/workflows/test.yml Outdated
Comment thread action.yml Outdated
@mayeut mayeut force-pushed the action-tool-cache branch from 22ca5bb to 5f12f8a Compare May 23, 2022 18:42
@mayeut mayeut marked this pull request as draft May 26, 2022 15:00
@mayeut mayeut force-pushed the action-tool-cache branch from 5f12f8a to 22791f6 Compare June 6, 2022 11:52
Comment thread action.yml
@mayeut mayeut force-pushed the action-tool-cache branch 2 times, most recently from 462cc77 to ce113a1 Compare June 23, 2022 19:54
@mayeut mayeut force-pushed the action-tool-cache branch from ce113a1 to 25c1bf5 Compare June 29, 2022 20:09
Comment thread action.yml Outdated

@joerick joerick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henryiii

Copy link
Copy Markdown
Contributor

Ahh, v4 doesn't point at v4.1.0 yet. Why is this passing, actually?

@mayeut

mayeut commented Jul 12, 2022

Copy link
Copy Markdown
Member Author

Why is this passing, actually?

Seems that invalid inputs are just warnings... Since Python gets setup properly, there's no reason for the workflow to fail.

Warning: Unexpected input(s) 'update-environment', valid inputs are ['python-version', 'python-version-file', 'cache', 'architecture', 'token', 'cache-dependency-path']

Let's wait for v4 being tagged again.
I'm not sure it's worth adding another workflow to test the action does not update the environment.

@henryiii

henryiii commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

v4 tag has been moved. I've moved the test to 18.04 to verify that works as expected. (though we'd need to drop 3.6 to verify it's working I guess since cibulidwheel works the built-in 3.6 & cibuildwheel doesn't print the host Python version).

@henryiii henryiii marked this pull request as ready for review July 13, 2022 13:58
@henryiii

Copy link
Copy Markdown
Contributor

This also should avoid getting the CMake environment variables set pointing at the global Python instance (also added in 4.1.0).

@joerick

joerick commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Shall we go back to ubuntu-latest runner before merging?

@henryiii

Copy link
Copy Markdown
Contributor

Leaving this until after we drop 3.6 might be helpful. Okay either way.

@mayeut

mayeut commented Jul 14, 2022

Copy link
Copy Markdown
Member Author

Let's get this in then.

@mayeut mayeut merged commit 88d432c into pypa:main Jul 14, 2022
@mayeut mayeut deleted the action-tool-cache branch July 14, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants