Import CompileError from setuptools not distutils#277
Merged
Conversation
This is to ensure that we get python/typeshed#10057 so that #277 is resolved.
Contributor
Author
|
Got it!!! Now it's just a matter of the standard tests completing. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 171 171
Lines 45433 45433
Branches 11094 11094
=======================================
Hits 36560 36560
Misses 6640 6640
Partials 2233 2233
|
Member
|
Looks good, can you revert c3bfe66 in order to close the original issue? |
ricardoV94
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In combination wtih python/typeshed#10057, closes #240.
Motivation for these changes
Fix failing CI
Implementation details
Update deprecated import
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance