Skip to content

Dataset subset assignments in doc#5378

Merged
max-sixty merged 7 commits intopydata:masterfrom
matzegoebel:doc
Jun 12, 2021
Merged

Dataset subset assignments in doc#5378
max-sixty merged 7 commits intopydata:masterfrom
matzegoebel:doc

Conversation

@matzegoebel
Copy link
Copy Markdown
Contributor

@matzegoebel matzegoebel commented May 26, 2021

Added explanation of new feature (PR #5045) that allows assigning values to a subset of a dataset to the documentation.

Copy link
Copy Markdown
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @matzegoebel

Comment thread doc/user-guide/indexing.rst Outdated
Comment thread doc/user-guide/indexing.rst Outdated
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@max-sixty max-sixty added the plan to merge Final call for comments label May 27, 2021
Copy link
Copy Markdown
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a few more changes which I think might be worth changing before merging. Looks good otherwise, though.

Comment thread doc/user-guide/indexing.rst Outdated
Comment thread doc/user-guide/indexing.rst Outdated
Comment thread doc/user-guide/indexing.rst Outdated
Comment thread doc/user-guide/indexing.rst Outdated
Copy link
Copy Markdown
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a few more comments, but other than that we can probably merge (unless someone else has more comments?)

Comment thread doc/user-guide/indexing.rst Outdated
Comment thread doc/user-guide/indexing.rst
Comment thread doc/user-guide/indexing.rst Outdated
Comment thread doc/user-guide/indexing.rst Outdated
Copy link
Copy Markdown
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for the updates. I'll merge this in a day or two if there are no further comments.

@max-sixty
Copy link
Copy Markdown
Collaborator

Thanks @matzegoebel ! If you'd like to add a whatsnew, please feel free to in another PR

@max-sixty max-sixty merged commit bdba981 into pydata:master Jun 12, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bdba981. ± Comparison against base commit bdba981.

@keewis
Copy link
Copy Markdown
Collaborator

keewis commented Jun 13, 2021

Thanks @matzegoebel ! If you'd like to add a whatsnew, please feel free to in another PR

there's already one for the new feature so the most that should be done is adding this PR to that entry (definitely optional, though).

Thanks again, @matzegoebel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants