Dataset subset assignments in doc#5378
Conversation
max-sixty
left a comment
There was a problem hiding this comment.
Looks good! Thanks @matzegoebel
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
keewis
left a comment
There was a problem hiding this comment.
I've got a few more changes which I think might be worth changing before merging. Looks good otherwise, though.
keewis
left a comment
There was a problem hiding this comment.
I've got a few more comments, but other than that we can probably merge (unless someone else has more comments?)
keewis
left a comment
There was a problem hiding this comment.
great, thanks for the updates. I'll merge this in a day or two if there are no further comments.
|
Thanks @matzegoebel ! If you'd like to add a whatsnew, please feel free to in another PR |
there's already one for the new feature so the most that should be done is adding this PR to that entry (definitely optional, though). Thanks again, @matzegoebel. |
Added explanation of new feature (PR #5045) that allows assigning values to a subset of a dataset to the documentation.