Better error message when no backend engine is found.#5300
Merged
shoyer merged 5 commits intopydata:masterfrom May 18, 2021
Merged
Better error message when no backend engine is found.#5300shoyer merged 5 commits intopydata:masterfrom
shoyer merged 5 commits intopydata:masterfrom
Conversation
I consider this progress towards fixing GH5291 but not a complete fix yet.
Member
Author
|
@alexamici @aurghs any thoughts? |
keewis
reviewed
May 14, 2021
Comment on lines
+39
to
+45
| file_formats = { | ||
| "air_temperature": 3, | ||
| "rasm": 3, | ||
| "ROMS_example": 4, | ||
| "tiny": 3, | ||
| "eraint_uvz": 3, | ||
| } |
Collaborator
There was a problem hiding this comment.
should we also mention the backend in the list of the available datasets for open_dataset?
Member
Author
There was a problem hiding this comment.
This would be a good idea for future work :)
Member
@alexamici @aurghs, the gentlest of bumps on this. Have a few minutes to take a look at this? 😄 |
Collaborator
|
That's perfect. |
aurghs
approved these changes
May 18, 2021
andersy005
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes a better error message when loading a tutorial dataset but an underlying IO dependency is not found.
pre-commit run --all-files