More robust guess_can_open for netCDF4/scipy/h5netcdf entrypoints#5296
Merged
shoyer merged 3 commits intopydata:masterfrom May 14, 2021
Merged
More robust guess_can_open for netCDF4/scipy/h5netcdf entrypoints#5296shoyer merged 3 commits intopydata:masterfrom
shoyer merged 3 commits intopydata:masterfrom
Conversation
The new version check magic numbers in files on disk, not just already open file objects. I've also added a bunch of unit-tests. Fixes GH5295
max-sixty
approved these changes
May 12, 2021
Member
Author
|
Thanks @max-sixty for review! Anyone else want to take a look? Maybe @alexamici @aurghs ? If not, I"ll probably self-merge this in a few days... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version checks magic numbers in files on disk, not just already open file objects.
I've also added a bunch of unit-tests.
Fixes GH5295
pre-commit run --all-fileswhats-new.rst