Add join='override'#3175
Merged
dcherian merged 19 commits intopydata:masterfrom Aug 16, 2019
Merged
Conversation
dcherian
commented
Aug 1, 2019
* master: enable sphinx.ext.napoleon (pydata#3180) remove type annotations from autodoc method signatures (pydata#3179) Fix regression: IndexVariable.copy(deep=True) casts dtype=U to object (pydata#3095) Fix distributed.Client.compute applied to DataArray (pydata#3173)
This reverts commit 8263d38.
* master: pyupgrade one-off run (pydata#3190) mfdataset, concat now support the 'join' kwarg. (pydata#3102) reduce the size of example dataset in dask docs (pydata#3187) add climpred to related-projects (pydata#3188) bump rasterio to 1.0.24 in doc building environment (pydata#3186) More annotations (pydata#3177) Support for __array_function__ implementers (sparse arrays) [WIP] (pydata#3117) Internal clean-up of isnull() to avoid relying on pandas (pydata#3132) Call darray.compute() in plot() (pydata#3183) BUG: fix + test open_mfdataset fails on variable attributes with list… (pydata#3181)
* commit 'f172c673': ENH: Scatter plots of one variable vs another (pydata#2277) Escape code markup (pydata#3189)
* commit 'd089df38': Black (pydata#3142)
Contributor
|
Hi, This doesn't close #2039 because
|
Contributor
Author
|
Ah, good point. Do you have any thoughts on the implementation? or on the |
Contributor
* upstream/master: Ignore example.grib.0112.idx file (pydata#3198) small updates to the contributing.rst (it could use more) (pydata#3193) Remove future statements (pydata#3194) update instructions (pydata#3195)
Contributor
Author
|
Ready for review. |
shoyer
reviewed
Aug 13, 2019
Member
shoyer
left a comment
shoyer
left a comment
There was a problem hiding this comment.
I think this general approach makes sense 👍
shoyer
approved these changes
Aug 15, 2019
Member
|
LGTM -- anyone else have opinions here? |
Collaborator
|
Yes agree! Thanks @dcherian ! |
Contributor
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
join='override'which checks that indexes along a dimension are of the same size and overwrites those indices with indices from the first object.Definitely need help, feedback.
whats-new.rstfor all changes andapi.rstfor new API