scheduled upstream-dev CI is skipped

[keewis]

The scheduled CI is being skipped since about 6 days ago (which means this is probably due to the merge of #4729, see this run before the merge and this run after the merge).

This is really strange because workflow_dispatch events (for which the CI detection job is also skipped) still work perfectly fine.

Edit: it seems to be because of

xarray/.github/workflows/upstream-dev-ci.yaml

Lines 34 to 37 in f52a95c

	&& (
	(github.event_name == 'scheduled' || github.event_name == 'workflow_dispatch')
	|| needs.detect-ci-trigger.outputs.triggered == 'true'
	)

if I remove that the scheduled CI runs.

cc @andersy005

[keewis]

the trigger also seems to be broken: the action fails because HEAD^2 apparently is not always a valid ref for pull request events.

[andersy005]

@keewis, I think the issue has to do with a typo in this condition:

xarray/.github/workflows/upstream-dev-ci.yaml

Line 35 in fb67358

(github.event_name == 'scheduled' || github.event_name == 'workflow_dispatch')

The right event name is schedule instead of scheduled: github.event_name == 'scheduled' --> github.event_name == 'schedule'

[keewis]

Oh, thanks, that makes sense. I'll send in a PR.

[andersy005]

the trigger also seems to be broken: the action fails because HEAD^2 apparently is not always a valid ref for pull request events.

Do you have any thoughts on how to address this?

[keewis]

I'm currently experimenting in #4805, but maybe we have to be smarter about how many commits to fetch.

Edit: it seems that this only fails for merge commits. that's wrong, I don't know why it fails