Add and expose typed PreconditionerVariant - #251
Open
leostimpfle wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the "variant" part of #236. I'll address the "build times" in a second PR.
I've made three key design choices (which can be debated):
PreconditionerVariantenum representing the algorithm of a built preconditioner:AdditiveorDiagonal.PreconditionerConfig: the config describes a construction request while the variant describes what an existingPreconditionercontains.Preconditioner::variant_name()for backward compatibility, but deprecated it in favour of the typedPreconditionerVariant. (This is mostly to avoid a having to bump the version to 0.4.0.)