fix: split import-test-nonabi3 per platform to remove needs coupling - #246
Merged
Conversation
Same bug class as #243: needs: [linux-nonabi3, macos-nonabi3, windows-nonabi3] made every test leg (including Linux/Windows-only ones) wait for, and get skipped by, an unrelated platform's build. macos-nonabi3 (macos-15-intel) is consistently the slowest of the three builds — confirmed via job logs it's not a cache miss, but the LTO relink cost of the release profile on that runner's hardware — so Linux/Windows tests were needlessly gated on it. Splits into import-test-nonabi3-{linux,macos,windows}, each needing only its own platform's build job. Doesn't change overall run duration (macOS stays the critical path for its own tests), but a macOS build failure no longer skips unrelated Linux/Windows checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same bug class fixed in #243: `needs: [linux-nonabi3, macos-nonabi3, windows-nonabi3]` made every import-test-nonabi3 leg wait for, and get skipped by, an unrelated platform's build. `macos-nonabi3 (macos-15-intel)` is consistently the slowest of the three build jobs (confirmed via job logs: 100% sccache hit rate, so it's LTO relink cost on that runner's hardware, not a cache miss) — so Linux/Windows tests were needlessly gated on a platform they don't depend on.
Splits into `import-test-nonabi3-{linux,macos,windows}`, each needing only its own platform's build job.
Doesn't change overall Wheels run duration — macOS stays the critical path for its own tests either way — but a macOS build failure (or its longer, more variable build time) no longer delays or skips the unrelated Linux/Windows checks.