Add missing Buffer APIs; update CI: node and actions versions#55
Merged
JordanMartinez merged 7 commits intomasterfrom Jul 5, 2023
Merged
Add missing Buffer APIs; update CI: node and actions versions#55JordanMartinez merged 7 commits intomasterfrom
JordanMartinez merged 7 commits intomasterfrom
Conversation
Contributor
Author
4 tasks
thomashoneyman
approved these changes
Jul 5, 2023
Contributor
|
Since we're pointing to Node v18 here, what do you think of updating CI to point to Node 18 (or perhaps to just the Node LTS, which is Node 18 and will become Node 20 soon)? purescript-node-buffer/.github/workflows/ci.yml Lines 20 to 22 in c6533da |
Contributor
Author
|
Sure. |
JordanMartinez
changed the title
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "14" | ||
| node-version: "latest" |
Contributor
There was a problem hiding this comment.
We can stick to the LTS via lts/* if we want to be on something stable, but latest is also fine by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds more APIs. This may not cover all the APIs but it does add a few more.
Checklist: