Fix the dev install to be absolute.#2
Merged
bowlofeggs merged 1 commit intopulp:masterfrom Oct 20, 2014
Merged
Conversation
pulp-dev.py
Outdated
Member
There was a problem hiding this comment.
Since _ are a convention for private methods and this is accessing it publicly (not using self) consider renaming _manage_setup_pys to manage_setup_pys. (no underscore).
Author
There was a problem hiding this comment.
Yeah I missed that when I moved it from Pulp's pulp-dev.py to it's environment. However, that is a comment for the pulp repo, not this one.
Author
There was a problem hiding this comment.
I submitted another PR for this issue: pulp/pulp#1252
Author
There was a problem hiding this comment.
I've fixed this. I'm going to go ahead and merge this before the pulp PR goes in because it'll only affect me and I'm cool with it.
Member
|
LGTM |
bowlofeggs
force-pushed
the
dev_install
branch
from
383aec3 to
9268a1b
Compare
asmacdo
referenced
this pull request
in asmacdo/pulp_python
Mar 31, 2016
Fixed tests and comments according to comments in pull-req pulp#121
werwty
added a commit
to werwty/pulp_python
that referenced
this pull request
Dec 15, 2017
# This is the 1st commit message: Add sync to pulp_python # The commit message pulp#2 will be skipped: # address pr feedback # The commit message pulp#3 will be skipped: # fix flake8 # The commit message pulp#4 will be skipped: # add docstrings # The commit message pulp#5 will be skipped: # update delta calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.