Skip to content

conformance: xUnit v3 migration, config hygiene, --pull=always lint tasks #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 1 commit into from
Jul 12, 2026
+7 −26
Merged

conformance: xUnit v3 migration, config hygiene, --pull=always lint tasks #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .vscode/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
"label": "Lint: EditorConfig",
"type": "process",
"command": "docker",
"args": [ "run", "--rm", "-v", "${workspaceFolder}:/check", "-w", "/check", "mstruebing/editorconfig-checker:latest" ],
"args": [ "run", "--rm", "--pull=always", "-v", "${workspaceFolder}:/check", "-w", "/check", "mstruebing/editorconfig-checker:latest" ],
"problemMatcher": [],
"presentation": {
"showReuseMessage": false,
Expand All @@ -150,7 +150,7 @@
"label": "Lint: Workflows",
"type": "process",
"command": "docker",
"args": [ "run", "--rm", "-v", "${workspaceFolder}:/repo", "-w", "/repo", "rhysd/actionlint:latest", "-color" ],
"args": [ "run", "--rm", "--pull=always", "-v", "${workspaceFolder}:/repo", "-w", "/repo", "rhysd/actionlint:latest", "-color" ],
"problemMatcher": [],
"presentation": {
"showReuseMessage": false,
Expand All @@ -161,7 +161,7 @@
"label": "Lint: Markdown",
"type": "process",
"command": "docker",
"args": [ "run", "--rm", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "davidanson/markdownlint-cli2:latest", "**/*.md" ],
"args": [ "run", "--rm", "--pull=always", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "davidanson/markdownlint-cli2:latest", "**/*.md" ],
"problemMatcher": [],
"presentation": {
"showReuseMessage": false,
Expand All @@ -172,7 +172,7 @@
"label": "Lint: Spelling",
"type": "process",
"command": "docker",
"args": [ "run", "--rm", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "ghcr.io/streetsidesoftware/cspell:latest", "--no-progress", "README.md", "HISTORY.md" ],
"args": [ "run", "--rm", "--pull=always", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "ghcr.io/streetsidesoftware/cspell:latest", "--no-progress", "README.md", "HISTORY.md" ],
"problemMatcher": [],
"presentation": {
"showReuseMessage": false,
Expand Down
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
<PackageVersion Include="Serilog" Version="4.4.0" />
<PackageVersion Include="Serilog.Extensions.Logging" Version="10.0.0" />
<PackageVersion Include="Serilog.Sinks.Console" Version="6.1.1" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.analyzers" Version="1.27.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageVersion Include="xunit.v3" Version="3.2.2" />
</ItemGroup>
</Project>
3 changes: 0 additions & 3 deletions UtilitiesTests/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,3 @@ dotnet_diagnostic.CA1707.severity = none

# CA1515: xUnit discovers only public test classes, so they cannot be internal.
dotnet_diagnostic.CA1515.severity = none

# CA2007: xUnit forbids ConfigureAwait in test methods (xUnit1030), so CA2007 cannot be satisfied in test code.
dotnet_diagnostic.CA2007.severity = none
20 changes: 2 additions & 18 deletions UtilitiesTests/UtilitiesTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
<Authors>Pieter Viljoen</Authors>
<Company>Pieter Viljoen</Company>
<Copyright>Pieter Viljoen</Copyright>
<Description>Generally useful utility classes</Description>
<Version>1.1.0.1</Version>
<FileVersion>1.1.0.1</FileVersion>
<AssemblyVersion>1.1.0.0</AssemblyVersion>
<PackageId>ptr727.Utilities.Tests</PackageId>
<AssemblyName>UtilitiesTests</AssemblyName>
<IsTestProject>true</IsTestProject>
<RootNamespace>ptr727.Utilities.Tests</RootNamespace>
<NeutralLanguage>en</NeutralLanguage>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="AwesomeAssertions" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
<PackageReference Include="xunit" />
<PackageReference Include="xunit.v3" />
<PackageReference Include="xunit.analyzers">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down