Skip to content

Carry template upstream-drift reporting paragraph into copilot-instructions#367

Merged
ptr727 merged 1 commit into
developfrom
docs/template-convergence
Jul 3, 2026
Merged

Carry template upstream-drift reporting paragraph into copilot-instructions#367
ptr727 merged 1 commit into
developfrom
docs/template-convergence

Conversation

@ptr727

@ptr727 ptr727 commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Closes the last substantive verbatim-carry gap found while auditing this repo against ptr727/ProjectTemplate for the convergence issues #329 and #339.

What changed

  • .github/copilot-instructions.md: append the template's "In a derived repo:" paragraph (verbatim) to the "When in Doubt" section, directing contributors to open an upstream issue in ptr727/ProjectTemplate when a discrepancy belongs in the template rather than only fixing it locally.

Audit result (context)

A full audit of #329 and #339 against the current template found nearly everything already converged (this repo is intentionally NuGet-only, no codegen, no Docker):

The only outstanding item was this one paragraph.

Issue-closing keywords are intentionally omitted here (this PR targets develop); Closes #329/Closes #339 will go on the develop -> main promotion PR so GitHub fires them on merge to the default branch.

Note: issue #348 (branch-ruleset drift) is maintainer-gated live-config and is intentionally not addressed here.

Add the "In a derived repo:" paragraph from the template's copilot-instructions
"When in Doubt" section (verbatim carry) - directs contributors to open an
upstream issue in ptr727/ProjectTemplate when a discrepancy belongs in the
template rather than only fixing it locally. Closes the last verbatim-carry gap
from the template re-sync audit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 3, 2026 17:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Copilot review runbook documentation to include the upstream template guidance for reporting “template-level” drift, ensuring derived repos feed back discrepancies to ptr727/ProjectTemplate instead of only patching locally.

Changes:

  • Appends the template’s “In a derived repo:” paragraph to the “When in Doubt” section of .github/copilot-instructions.md.
  • Adds direct links to the upstream ptr727/ProjectTemplate repo and the specific AGENTS.md section describing drift reporting.

@ptr727
ptr727 merged commit 659176c into develop Jul 3, 2026
10 checks passed
@ptr727
ptr727 deleted the docs/template-convergence branch July 3, 2026 17:50
ptr727 added a commit that referenced this pull request Jul 3, 2026
Promotes the two commits currently ahead on `develop` to `main`.

Closes #329
Closes #339

## What's promoted
- **#367** - carry the template's "In a derived repo:" upstream-drift
reporting paragraph into `.github/copilot-instructions.md`. This was the
last substantive verbatim-carry gap from a full audit of both
convergence issues against `ptr727/ProjectTemplate`.
- **#366** - record two CI/CD process learnings in `AGENTS.md` (mirror
main-only fixes back to `develop` with a content-diff staleness check;
put `Closes #N` on the promotion PR), converged through the Copilot
review loop.

## Convergence audit (why #329 and #339 are done)
Audited every item in both issues against the current template. This
repo is intentionally NuGet-only, no codegen, no Docker, so most items
were already converged by prior work:
- **#329**: the Copilot review runbook
(`.github/copilot-instructions.md`), the AGENTS.md "PR Review Etiquette"
contract, and `.markdownlint-cli2.jsonc` (byte-identical to the
template) are all present. Only the "In a derived repo:" paragraph was
missing (#367).
- **#339**: `.editorconfig` `[*.cs]` marked .NET-only with matching
per-extension EOL rules; AGENTS.md comments house-rule, markdown
trailing-backslash, and versioning-without-"develop-ahead";
`CODESTYLE.md` (General + .NET, Python dropped); `retention-days: 1` on
the one artifact upload. Docker registry-cache guidance is N/A (no
Docker workflow).

Remaining differences are intentional, repo-accurate divergence
(NuGet-only project names, `CODESTYLE.md` build-requirements text
matching this repo's actual `Directory.Build.props`).

## Not included
Issue **#348** (branch-ruleset drift: extra `creation` rule +
`do_not_enforce_on_create`) is maintainer-gated live GitHub config and
is intentionally left for a maintainer decision (whether the extra
`creation` rule is intended). Surfaced separately, not closed here.

## Diff
`develop` is a clean superset of `main` (4 insertions across two doc
files, no deletions - no `main`-only stragglers).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants