Keep jq stderr in jq_lacks (converge configure.sh)#355
Merged
Conversation
Discard only stdout (drop 2>&1) and reflow the comment to the canonical wrapping. jq's exit 0/1/4 cases produce no stderr so normal runs stay silent, but a real jq error (2/3/5) now prints its message. Converges repo-config/configure.sh with the other three repos. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the repo-config/configure.sh validation helpers so jq_lacks no longer suppresses jq diagnostics, making real jq errors (exit 2/3/5) visible during configuration audits while keeping normal runs quiet.
Changes:
- Update
jq_lacksto discard only stdout (keep stderr) so realjqfailures surface useful error messages. - Reflow the
jq_lackscomment to the canonical wrapping without changing behavior.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discard only stdout in
jq_lacks(drop2>&1) and reflow the comment to the canonical wrapping. jq's exit 0/1/4 cases produce no stderr so normal audit runs stay silent, but a real jq error (exit 2/3/5) now prints its diagnostic instead of failing silently.Converges
repo-config/configure.shbyte-for-byte with the other three repos, where Copilot surfaced this. Verified:bash -n, shellcheck.