Skip to content

Tighten jq_lacks doc summary#354

Merged
ptr727 merged 1 commit into
developfrom
fix/jq-lacks-comment
Jun 29, 2026
Merged

Tighten jq_lacks doc summary#354
ptr727 merged 1 commit into
developfrom
fix/jq-lacks-comment

Conversation

@ptr727

@ptr727 ptr727 commented Jun 29, 2026

Copy link
Copy Markdown
Owner

The summary said 'selects nothing'; jq_lacks also treats exit 1 (false/null output) as lacks. Reword to 'yields no truthy value (selects nothing, or only false/null)'. Follow-up to #351/#352.

The summary said "selects nothing"; the function also treats exit 1 (false/null output) as
"lacks". Say "yields no truthy value (selects nothing, or only false/null)".

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 29, 2026 04:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the in-file documentation for the jq_lacks helper in repo-config/configure.sh to better describe how it interprets jq -e exit codes, aligning the comment with the helper’s intended “lacks” semantics.

Changes:

  • Reword jq_lacks doc comment to include the “false/null output” case (jq -e exit 1), not just “selects nothing”.
  • Split the updated description across multiple comment lines for readability.

Comment thread repo-config/configure.sh
@ptr727
ptr727 merged commit 87e13de into develop Jun 29, 2026
10 checks passed
@ptr727
ptr727 deleted the fix/jq-lacks-comment branch June 29, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants