Skip to content

Adopt shared markdownlint config and lint-clean docs#330

Merged
ptr727 merged 4 commits into
developfrom
realign-template-lint-config
Jun 8, 2026
Merged

Adopt shared markdownlint config and lint-clean docs#330
ptr727 merged 4 commits into
developfrom
realign-template-lint-config

Conversation

@ptr727

@ptr727 ptr727 commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Addresses #329 - realign with ptr727/ProjectTemplate.

  • Shared lint config: carry .markdownlint-cli2.jsonc verbatim; normalize blank lines / label a fence so docs pass clean.
  • Review-loop contract: add the template's PR Review Etiquette section to AGENTS.md.
  • Copilot runbook: append the GitHub Copilot Review Runbook to .github/copilot-instructions.md (owner/repo adapted to ptr727/Utilities).
  • Line endings: normalize both touched files to CRLF per .editorconfig (they had pre-existing mixed CRLF/LF), and drop a whitespace-only line in a code example.

Per your confirmation, this repo adopts the full review-loop docs despite being NuGet-only. Its .editorconfig already governs line endings, so no editorconfig rule change was needed.

Carry the template's .markdownlint-cli2.jsonc verbatim so the davidanson IDE
extension and CLI markdownlint-cli2 apply the same rules. Normalize blank lines
around headings/fences/lists and label one fenced block in
copilot-instructions.md so the repo passes cleanly under the shared config (0
errors). The existing .editorconfig already governs line endings (global crlf
+ lf overrides), so no editorconfig change was needed.

Realigns with ptr727/ProjectTemplate. Part of #329.
Copilot AI review requested due to automatic review settings June 8, 2026 15:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the repository’s Markdown linting and documentation formatting with the shared ptr727/ProjectTemplate conventions by adding a markdownlint-cli2 configuration and making documentation edits so the repo’s Markdown passes cleanly under that config.

Changes:

  • Add a shared .markdownlint-cli2.jsonc configuration at the repo root to standardize Markdown lint rules.
  • Normalize spacing/blank lines in .github/copilot-instructions.md to satisfy markdownlint rules.
  • Label the conventional-commit fenced block as text and wrap a bare URL in angle brackets to avoid common markdownlint violations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.markdownlint-cli2.jsonc Introduces a shared markdownlint-cli2 config so IDE/CLI/CI linting uses the same rules.
.github/copilot-instructions.md Formatting-only markdown cleanup (blank lines, fenced block language, bare URL) to lint-clean under the shared config.

Add the template's 'PR Review Etiquette' contract to AGENTS.md and append the
'GitHub Copilot Review Runbook' to .github/copilot-instructions.md (owner/repo
adapted to ptr727/Utilities). Both were previously absent, leaving an agent
here with no in-repo pointer to the reliable Copilot review mechanics. Part of
#329.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread AGENTS.md Outdated
Comment thread .github/copilot-instructions.md Outdated
ptr727 added 2 commits June 8, 2026 09:26
…nfig

These files had pre-existing mixed CRLF/LF line endings; .editorconfig mandates
CRLF for .md. Normalize both fully to CRLF so the carried template sections and
the existing content share consistent, compliant endings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread .github/copilot-instructions.md
@ptr727
ptr727 merged commit a9fc0c0 into develop Jun 8, 2026
7 checks passed
ptr727 added a commit that referenced this pull request Jun 8, 2026
…unbook (#331)

Promotes `develop` to `main`. Realignment with ProjectTemplate (#330):
shared markdownlint config, PR Review Etiquette + Copilot review
runbook, CRLF normalization. Also rolls up dependency bumps (#325-#327).
@ptr727
ptr727 deleted the realign-template-lint-config branch July 7, 2026 21:05
ptr727 added a commit that referenced this pull request Jul 16, 2026
…417)

Implements the fleet hub drift finding (ProjectTemplate #330): earlier
downstream carries drifted from the current repo-config and merge-bot
reference.

## Repo-config carry refresh

- Rename `repo-config/ruleset-develop.json` and `ruleset-main.json` to
`develop.json` and `main.json`, matching the current fleet reference
layout (the fleet audit letter-checks the new paths).
- Refresh `README.md`, `configure.sh`, and `settings.json` to the
current reference content.

## Self-audit carry

- Add `AUDIT.md` at the repo root plus `spec/secrets.json` per the
repo-config Downstream Carry, adapted from the blessed Vantage-Config
reference for this repo's release model with the nuget-oidc and codecov
secret mechanisms.

## Merge-bot workflow sync

- Sync `.github/workflows/merge-bot-pull-request.yml` to the current
fleet reference: notably `gh pr merge` no longer uses `--delete-branch`,
and the header and comments are updated.

## Scope

Live rulesets, settings, and secrets were verified in sync with the
reference payloads today; this change touches committed files only. No
live repo configuration was modified.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants