Skip to content

Promote develop to main#261

Merged
ptr727 merged 1 commit into
mainfrom
develop
Jul 11, 2026
Merged

Promote develop to main#261
ptr727 merged 1 commit into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Promote develop to main.

Single change: test coverage and Codecov configuration (#260), test and config only, no functional/library behavior changes.

  • codecov.yml (informational, scoped to the library, generated code ignored)
  • Roslyn parse validation for SaveCodeAsync, plus LanguageSchema/LogExtensions coverage
  • redundant test .editorconfig overrides removed
  • Microsoft.CodeAnalysis.CSharp test-only dependency

Hand-written coverage ~76.6% -> ~91.6% (310 tests). Follow-up tracked in #259.

🤖 Generated with Claude Code

Test and configuration changes only, no functional/library behavior changes.

- codecov.yml scoped to the LanguageTags library, generated code ignored, kept informational until a default-branch baseline is established.
- SaveCodeAsync tests parse emitted C# with Roslyn; LanguageSchema.GetCodeGenString and LogExtensions covered.
- LogExtensions tests assert the exception is logged at Error via a capturing logger.
- Dropped redundant test .editorconfig overrides (IDE0058/IDE0052/CS1591); discards satisfy IDE0058.
- Microsoft.CodeAnalysis.CSharp added as a test-only dependency.

Hand-written coverage ~76.6% -> ~91.6% (310 tests).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 11, 2026 01:50
@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.43%. Comparing base (be1c95a) to head (ebec6e9).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #261       +/-   ##
===========================================
- Coverage   99.76%   87.43%   -12.34%     
===========================================
  Files          15       11        -4     
  Lines      232994     1973   -231021     
  Branches      243      243               
===========================================
- Hits       232450     1725   -230725     
+ Misses        462      166      -296     
  Partials       82       82               

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes develop to main by bringing in the test-coverage and Codecov configuration work (no functional library behavior changes), improving confidence in codegen emitters and logging helpers.

Changes:

  • Add Roslyn-based syntax validation tests for SaveCodeAsync output across the ISO/RFC/UN data types.
  • Add unit tests for LanguageSchema.GetCodeGenString and for LogExtensions.LogAndPropagate / LogAndHandle.
  • Introduce codecov.yml, remove redundant test .editorconfig suppressions, and add a test-only Microsoft.CodeAnalysis.CSharp dependency (centralized in Directory.Packages.props).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
LanguageTagsTests/UnM49Tests.cs Adds SaveCodeAsync code emission + Roslyn parse validation coverage for UN M.49.
LanguageTagsTests/Rfc5646Tests.cs Adds SaveCodeAsync code emission + Roslyn parse validation coverage for RFC 5646.
LanguageTagsTests/Iso6393Tests.cs Adds SaveCodeAsync code emission + Roslyn parse validation coverage for ISO 639-3.
LanguageTagsTests/Iso6392Tests.cs Adds SaveCodeAsync code emission + Roslyn parse validation coverage for ISO 639-2.
LanguageTagsTests/LogExtensionsTests.cs Adds tests validating logging level/exception capture and boolean return behavior of logging helpers.
LanguageTagsTests/LanguageSchemaTests.cs Adds direct unit coverage for codegen string formatting helpers (strings, dates, enums, and quote escaping in lists).
LanguageTagsTests/LanguageTagsTests.csproj Adds Roslyn (Microsoft.CodeAnalysis.CSharp) package reference for syntax validation tests.
LanguageTagsTests/.editorconfig Removes redundant test analyzer overrides; keeps xUnit-discovery-related suppressions.
Directory.Packages.props Centralizes the Roslyn package version used by the test project.
codecov.yml Adds Codecov configuration scoped to the library, ignoring generated code and non-library projects.

Comment thread LanguageTagsTests/Iso6392Tests.cs
@ptr727
ptr727 merged commit 621ff8f into main Jul 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants