Conversation
Test and configuration changes only, no functional/library behavior changes. - codecov.yml scoped to the LanguageTags library, generated code ignored, kept informational until a default-branch baseline is established. - SaveCodeAsync tests parse emitted C# with Roslyn; LanguageSchema.GetCodeGenString and LogExtensions covered. - LogExtensions tests assert the exception is logged at Error via a capturing logger. - Dropped redundant test .editorconfig overrides (IDE0058/IDE0052/CS1591); discards satisfy IDE0058. - Microsoft.CodeAnalysis.CSharp added as a test-only dependency. Hand-written coverage ~76.6% -> ~91.6% (310 tests). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
===========================================
- Coverage 99.76% 87.43% -12.34%
===========================================
Files 15 11 -4
Lines 232994 1973 -231021
Branches 243 243
===========================================
- Hits 232450 1725 -230725
+ Misses 462 166 -296
Partials 82 82 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes develop to main by bringing in the test-coverage and Codecov configuration work (no functional library behavior changes), improving confidence in codegen emitters and logging helpers.
Changes:
- Add Roslyn-based syntax validation tests for
SaveCodeAsyncoutput across the ISO/RFC/UN data types. - Add unit tests for
LanguageSchema.GetCodeGenStringand forLogExtensions.LogAndPropagate/LogAndHandle. - Introduce
codecov.yml, remove redundant test.editorconfigsuppressions, and add a test-onlyMicrosoft.CodeAnalysis.CSharpdependency (centralized inDirectory.Packages.props).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LanguageTagsTests/UnM49Tests.cs | Adds SaveCodeAsync code emission + Roslyn parse validation coverage for UN M.49. |
| LanguageTagsTests/Rfc5646Tests.cs | Adds SaveCodeAsync code emission + Roslyn parse validation coverage for RFC 5646. |
| LanguageTagsTests/Iso6393Tests.cs | Adds SaveCodeAsync code emission + Roslyn parse validation coverage for ISO 639-3. |
| LanguageTagsTests/Iso6392Tests.cs | Adds SaveCodeAsync code emission + Roslyn parse validation coverage for ISO 639-2. |
| LanguageTagsTests/LogExtensionsTests.cs | Adds tests validating logging level/exception capture and boolean return behavior of logging helpers. |
| LanguageTagsTests/LanguageSchemaTests.cs | Adds direct unit coverage for codegen string formatting helpers (strings, dates, enums, and quote escaping in lists). |
| LanguageTagsTests/LanguageTagsTests.csproj | Adds Roslyn (Microsoft.CodeAnalysis.CSharp) package reference for syntax validation tests. |
| LanguageTagsTests/.editorconfig | Removes redundant test analyzer overrides; keeps xUnit-discovery-related suppressions. |
| Directory.Packages.props | Centralizes the Roslyn package version used by the test project. |
| codecov.yml | Adds Codecov configuration scoped to the library, ignoring generated code and non-library projects. |
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
developtomain.Single change: test coverage and Codecov configuration (#260), test and config only, no functional/library behavior changes.
Hand-written coverage ~76.6% -> ~91.6% (310 tests). Follow-up tracked in #259.
🤖 Generated with Claude Code