Skip to content

Promote: adopt ptr727.Utilities HttpClientFactory#258

Merged
ptr727 merged 1 commit into
mainfrom
develop
Jul 10, 2026
Merged

Promote: adopt ptr727.Utilities HttpClientFactory#258
ptr727 merged 1 commit into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Promotes to main the adoption of the shared ptr727.Utilities 4.0.7 HttpClientFactory / AssemblyInfo in place of the local copies.

  • LanguageTagsCreate references ptr727.Utilities and deletes its local HttpClientFactory.cs / AssemblyInfo.cs.
  • The download call uses Utilities.HttpClientFactory.GetClient(); the resilience pipeline and AOT-safe User-Agent come from the library.
  • The library ILogger logging is wired via Utilities.LogOptions.SetFactory(...).

Verified: build clean, dotnet format style clean, 296 tests passing.

🤖 Generated with Claude Code

Replace the local HttpClientFactory and AssemblyInfo copies with the shared ptr727.Utilities 4.0.7 versions; wire the library logger via LogOptions.SetFactory. Delete the local copies and drop the direct Microsoft.Extensions.Http.Resilience reference.
Copilot AI review requested due to automatic review settings July 10, 2026 20:10
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (adba4dc) to head (be1c95a).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          15       15           
  Lines      232994   232994           
  Branches      243      243           
=======================================
  Hits       232450   232450           
  Misses        462      462           
  Partials       82       82           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes to main the switch in LanguageTagsCreate from local implementations to the shared ptr727.Utilities package for HTTP client creation and shared assembly/logging utilities, reducing duplicated code in the codegen tool.

Changes:

  • Replace the local LanguageTagsCreate HttpClientFactory with ptr727.Utilities.HttpClientFactory.
  • Wire the shared ptr727.Utilities.LogOptions to the existing Serilog-backed ILoggerFactory.
  • Remove the local HttpClientFactory.cs and AssemblyInfo.cs and add ptr727.Utilities 4.0.7 to central package versions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
LanguageTagsCreate/Program.cs Sets both ptr727.LanguageTags.LogOptions and ptr727.Utilities.LogOptions to the same ILoggerFactory.
LanguageTagsCreate/LanguageTagsCreate.csproj Replaces direct resilience-related dependency usage with a ptr727.Utilities package reference.
LanguageTagsCreate/HttpClientFactory.cs Removes the local resilience-enabled HttpClient factory implementation.
LanguageTagsCreate/CreateTagData.cs Switches download stream acquisition to Utilities.HttpClientFactory.GetClient().
LanguageTagsCreate/AssemblyInfo.cs Removes the local assembly metadata helper previously used by the old HTTP client factory.
Directory.Packages.props Drops the now-unused resilience package version and adds ptr727.Utilities 4.0.7.

@ptr727
ptr727 merged commit e0ad1b2 into main Jul 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants