Cleanup output fields#399
Merged
JamesMcClung merged 27 commits intoApr 28, 2026
Merged
Conversation
it isn't used, so just replace it with its default of 0
I don't think it's actually necessary
no longer used
it doesn't use the grid
this does remove the outermost profiler wrapping both field and moments output, but hopefully profiling all diagnostics (in a previous commit) is an acceptable replacement.
would be great to infer Mfields, but I'm not feeling brave enough to untangle that correctly
this enables parameters (interval, dir) to be set after initialization
germasch
approved these changes
Apr 28, 2026
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
I'll admit I didn't look into every single change, but I definitely like the overall concept.
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
OutputFields(pfd) andOutputMoments(pfd_moments) distinct, usable diagnostics. Remove the wrapper type that combined them.