Skip to content

Add support /sys/devices/system/node/nodeN/meminfo#489

Open
khunafin wants to merge 3 commits into
prometheus:masterfrom
khunafin:meminfo_numa
Open

Add support /sys/devices/system/node/nodeN/meminfo#489
khunafin wants to merge 3 commits into
prometheus:masterfrom
khunafin:meminfo_numa

Conversation

@khunafin

Copy link
Copy Markdown

No description provided.

Signed-off-by: Nail Khunafin <nail.khunafin@gmail.com>
Comment thread sysfs/meminfo_numa.go Outdated

@discordianfish discordianfish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

Signed-off-by: Nail Khunafin <nail.khunafin@gmail.com>

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to fix the Go linter errors.

Signed-off-by: Nail Khunafin <nail.khunafin@gmail.com>
@tjhop

tjhop commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

I stumbled across this PR while investigating for #565. If the approach used in #569 is accepted, it would seem like a similar approach may be needed here as well

@PiotrProkop

Copy link
Copy Markdown

@khunafin are you planning to update this PR? If not I am willing to help with this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants