Replace deprecated linter#2176
Merged
Merged
Conversation
discordianfish
approved these changes
Oct 26, 2021
Member
discordianfish
left a comment
discordianfish
left a comment
There was a problem hiding this comment.
LGTM but tests are failing
Upstream is replacing `golint` with `revive`. * Cleanup unused mixin go files. Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/deprecated_linters
branch
from
4c7fa36 to
f451236
Compare
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Upstream is replacing `golint` with `revive`. * Cleanup unused mixin go files. Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Upstream is replacing `golint` with `revive`. * Cleanup unused mixin go files. Signed-off-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream is replacing
golintwithrevive.Signed-off-by: Ben Kochie superq@gmail.com