Modest doc improvements#1876
Merged
SuperQ merged 2 commits intoNov 25, 2020
Merged
Conversation
anthonyeleven
force-pushed
the
anthonyeleven/doc-tweaks
branch
from
23190c5 to
f112760
Compare
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
anthonyeleven
force-pushed
the
anthonyeleven/doc-tweaks
branch
from
f112760 to
bb0a97f
Compare
anthonyeleven
force-pushed
the
anthonyeleven/doc-tweaks
branch
from
65d22a3 to
1782fc2
Compare
Contributor
Author
|
@SuperQ @discordianfish The checks were a bit flaky but this PR has now passed and is ready to merge. PTAL. |
discordianfish
approved these changes
Nov 24, 2020
Member
discordianfish
left a comment
discordianfish
left a comment
There was a problem hiding this comment.
Nice, definitely an improvement, thanks!
Contributor
Author
You bet, happy to contribute. Is there more to be done for this to be merged? |
SuperQ
reviewed
Nov 25, 2020
SuperQ
reviewed
Nov 25, 2020
SuperQ
reviewed
Nov 25, 2020
Member
|
Nice, thanks for the improvements. I've add a few suggestions. |
anthonyeleven
force-pushed
the
anthonyeleven/doc-tweaks
branch
from
1782fc2 to
d22ae70
Compare
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Contributor
Author
You're welcome, Prometheus and node_exporter have been invaluable for me and I'm happy to contribute. I've pushed a revised commit, please take a look. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Modest doc improvements Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Modest doc improvements Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get my feet wet by tweaking some wording and adding some guidance wrt collectors that are disabled by default.
@SuperQ @discordianfish
Signed-off-by: Anthony D'Atri anthony.datri@gmail.com