Skip to content

Add an easy way to define preset labels globally #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefansundin wants to merge 1 commit into from
Closed

Add an easy way to define preset labels globally #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/prometheus/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ module Prometheus
# Client is a ruby implementation for a Prometheus compatible client.
module Client
# Returns a default registry object
def self.registry
@registry ||= Registry.new
def self.registry(labels: [], preset_labels: {})
@registry ||= Registry.new(labels: labels, preset_labels: preset_labels)
end

def self.config
Expand Down
20 changes: 11 additions & 9 deletions lib/prometheus/client/registry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ module Client
class Registry
class AlreadyRegisteredError < StandardError; end

def initialize
def initialize(labels: [], preset_labels: {})
@metrics = {}
@mutex = Mutex.new
@labels = labels
@preset_labels = preset_labels
end

def register(metric)
Expand All @@ -40,24 +42,24 @@ def unregister(name)
def counter(name, docstring:, labels: [], preset_labels: {}, store_settings: {})
register(Counter.new(name,
docstring: docstring,
labels: labels,
preset_labels: preset_labels,
labels: @labels + labels,
preset_labels: @preset_labels.merge(preset_labels),
store_settings: store_settings))
end

def summary(name, docstring:, labels: [], preset_labels: {}, store_settings: {})
register(Summary.new(name,
docstring: docstring,
labels: labels,
preset_labels: preset_labels,
labels: @labels + labels,
preset_labels: @preset_labels.merge(preset_labels),
store_settings: store_settings))
end

def gauge(name, docstring:, labels: [], preset_labels: {}, store_settings: {})
register(Gauge.new(name,
docstring: docstring,
labels: labels,
preset_labels: preset_labels,
labels: @labels + labels,
preset_labels: @preset_labels.merge(preset_labels),
store_settings: store_settings))
end

Expand All @@ -66,8 +68,8 @@ def histogram(name, docstring:, labels: [], preset_labels: {},
store_settings: {})
register(Histogram.new(name,
docstring: docstring,
labels: labels,
preset_labels: preset_labels,
labels: @labels + labels,
preset_labels: @preset_labels.merge(preset_labels),
buckets: buckets,
store_settings: store_settings))
end
Expand Down