Fix some issues with syncing projects on codeberg #5
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mgorny I've tested this with the full projects.xml and it seems to work. |
mgorny
reviewed
Feb 2, 2026
mgorny
reviewed
Feb 2, 2026
| # providing the Link header to the next page. We do get the | ||
| # X-Total-Count header which lets us work out the number of | ||
| # pages ourselves. | ||
| url = f"{self.orgs_baseurl}/{org}/teams/" |
Member
There was a problem hiding this comment.
I think it makes sense to increase the limit here and for other paginated data. It's not like we're going to do parts of it.
There's literally a missing Link. The Link header that is usually provided for paginated responses is simply not provided for this particular endpoint. Fortunately the X-Total-Count header is provided so we can work out how many pages to fetch. While we're at it, we increase the default page size as well. Signed-off-by: Thomas Bracht Laumann Jespersen <[email protected]>
The team description field is limited to 255 characters, so let's stick within that limit and truncate entries that are too long. Signed-off-by: Thomas Bracht Laumann Jespersen <[email protected]>
Using "devs.get(x)" instead of "x in devs" not only lets us filter out the cases where x is not in devs, but also the cases where the devs[x] entry is None or an empty string. Signed-off-by: Thomas Bracht Laumann Jespersen <[email protected]>
laumann
force-pushed
the
more-codeberg
branch
from
11046d0 to
ab33584
Compare
Contributor
Author
|
Filed a bug for the teams pagination issue: go-gitea/gitea#36516 UPDATE! A fix is in the making: https://codeberg.org/forgejo/forgejo/pulls/9910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkheader other paginated endpoints do - workaround withX-Total-Countcb_members