Fix for OCTA-24050

[hdanielsen]

Ensure the error message is showm in PDSOE dialog instgead of ABL: Call ShowOkMessage if oeideisrunning and can show message

[stefandrissen]

Is Progress accepting pull requests in github now? If so, I would put the message in a variable instead of duplicating message construction.

[hdanielsen]

Is Progress accepting pull requests in github now?

I doubt Progress has the bandwidth to accept pull requests in ADE, If you have fixes for issues you would probably need to discuss this with Product Management, Support or Development first. Since I did the main implementation of the PDSOE AppBuilder integration in the past I assisted Product Management and Development with several AppBuilder integration bugs a while ago. Most of these have already been shipped in version 12.6 (?). There are, however, two issues that I have fixed locally that has not shipped yet. I have been keeping track of these on my own waiting for Development to schedule them or the ADE to be moved to github. ADE has been moved github a while ago and I finally got around to check them in.

I have not informed Product Management and Development about this yet and do not know if/when this will be used.

I would put the message in a variable instead of duplicating message construction.

I generally agree, but the requirement for these fixes was to eliminate/minimize risk and need for testing in standalone Appbuilder.

• The old code that now is executed for standalone AppBuilder has SKIP in the message. This does not work when sent as text to PDS, so the message for PDS was implemented separately and differently.

• The fact that vrfyimp.i is an include used in several procedures in ADE complicates the introduction of a variable. Even if we would catch cases were a new variable collides with definitions in the source in our internal build, there are customers that have edited versions of Appbuilder code, so we could in theory break their code.