[FEAT] Add description in the 'blog' and 'news' pages#226
Merged
Conversation
tbouffard
added
enhancement
|
♻️ PR Preview e4453ee has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
8 tasks
csouchet
reviewed
Nov 17, 2021
tbouffard
force-pushed
the
187-add_description_in_blog_page
branch
from
b65fa5a to
a8e4813
Compare
csouchet
force-pushed
the
187-add_description_in_blog_page
branch
from
a8e4813 to
6c52840
Compare
csouchet
reviewed
Nov 23, 2021
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
tbouffard
force-pushed
the
187-add_description_in_blog_page
branch
from
1f69dc6 to
57bb415
Compare
tbouffard
changed the title
tbouffard
removed
the
WIP 🚧
csouchet
reviewed
Nov 26, 2021
Comment on lines
+56
to
+67
| <Heading | ||
| as="p" | ||
| color="primary" | ||
| fontSize={[2, 4]} | ||
| mb={[3, 5]} | ||
| textAlign="center" | ||
| style={centerHorizontally} | ||
| > | ||
| <Text width={[400, 600, 700]} key="presentation"> | ||
| {description} | ||
| </Text> | ||
| </Heading> |
Contributor
There was a problem hiding this comment.
There is a problem. The cards take the same witdh that this text.
Contributor
There was a problem hiding this comment.
Also, I would prefer to simplify this code and the rendered objects in the DOM, like:
Suggested change
| <Heading | |
| as="p" | |
| color="primary" | |
| fontSize={[2, 4]} | |
| mb={[3, 5]} | |
| textAlign="center" | |
| style={centerHorizontally} | |
| > | |
| <Text width={[400, 600, 700]} key="presentation"> | |
| {description} | |
| </Text> | |
| </Heading> | |
| <Text | |
| as="p" | |
| width={['85%', '80%', '70%']} | |
| color="primary" | |
| fontSize={[2, 4]} | |
| mb={[3, 5]} | |
| textAlign="center" | |
| style={centerHorizontally} | |
| > | |
| {description} | |
| </Text> |
It also is recommended to use 'rem' or '%' in place of 'px' in CSS.
It prevents some effect like:
| px | % |
|---|---|
 |
 |
Member
Author
There was a problem hiding this comment.
I am ok for using percentage instead of other configuration. I took the width values from existing we had from the site, so this should be applied everywhere.
Contributor
There was a problem hiding this comment.
In a future PR, I'll change all the unit for the different CSS styles 😉
csouchet
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
covers #187