Conversation
Match the dambis-kit setup: wp core from roots/wordpress, plugin mapped into wp-content/plugins via .wp-env.json.
- wpcs ^3.3 with phpcompatibility-wp, phpunit ^9.6 with wp-phpunit, phpstan, wp-cli bundle - add roots/wordpress for local core files - drop wp_mock, wpsh/local and php-coveralls
Replace WP_Mock unit tests with WP_UnitTestCase integration tests run inside wp-env via composer test.
- entry js/editor.js builds to build/editor.js - use @wordpress/* imports so dependencies land in editor.asset.php - drop babel, webpack, grunt and the wp.org deploy tasks
- declare BlockContext properties; dynamic properties are deprecated since PHP 8.2 - fix namespace-relative docblock types and a strign typo - guard direct access and require PHP 7.4 in plugin header
wp-scripts outputs build/editor.js; read dependencies and version from the generated editor.asset.php.
PHP 7.4 supports typed properties and scalar/nullable param and return types; add them everywhere except where the real type is a union or mixed, which need PHP 8.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.