cylinderFlap OpenFOAM: Remove residualControl, version-specific#78
cylinderFlap OpenFOAM: Remove residualControl, version-specific#78
Conversation
Instead, offer commented-out ways to get the residualControl in the various OpenFOAM versions, with the current values. This may affect convergence, but the purpose of the tutorial is to demonstrate how to configure preCICE and the adapters. This fixes #40.
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Can we we also make https://github.com/precice/tutorials/blob/cylinderFlap-of-version/FSI/cylinderFlap/OpenFOAM-FEniCS/Fluid/system/fvSolution consistent to the other files? I.e. providing the comments like //OpenFOAM 6 (.org) or newer that are introduced in this PR (writing this explicitly as a comment into the file is very helpful!) and using comments of the style /* ... */. I think it is mainly a question of style, but I would prefer having a consistent format everywhere.
I think
- https://github.com/precice/tutorials/blob/cylinderFlap-of-version/FSI/cylinderFlap_2D/OpenFOAM-deal.II/Fluid/system/fvSolution
- https://github.com/precice/tutorials/blob/cylinderFlap-of-version/FSI/3D_Tube/OpenFOAM-CalculiX/Fluid/system/fvSolution
also need an update.
|
@BenjaminRueth Good point, I found and updated more cases, including the 3D_Tube. Feel free to check again. I have not checked the results of the cases, let's let Travis deal with that. In the diff view, please set to "ignore whitespace", as I fixed a few formatting bits in these files as well. @Eder-K: This will probably slightly change the reference results. Note that the |
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Looks good 👍
I hope you don't expect me to run anything. If yes: Then just rerequest a review and I will try to do it soonish.
Instead, offer commented-out ways to get the residualControl in the various OpenFOAM versions, with the current values.
This may affect convergence, but the purpose of the tutorial is to demonstrate how to configure preCICE and the adapters.
This fixes #40.