Provide vector valued function for initialization#126
Closed
BenjaminRodenberg wants to merge 2 commits intodevelopfrom
Closed
Provide vector valued function for initialization#126BenjaminRodenberg wants to merge 2 commits intodevelopfrom
BenjaminRodenberg wants to merge 2 commits intodevelopfrom
Conversation
IshaanDesai
requested changes
Dec 10, 2020
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
The changes made are correct but there is another conflict elsewhere regarding passing a vector valued function to the adapter.
Member
|
In the time loop, only the y-component of the flux is provided to the # Dirichlet problem obtains flux from solution and sends flux on boundary to Neumann problem
determine_heat_flux(V_g, u_np1, k, fluxes)
fluxes_y = fluxes.sub(1) # only exchange y component of flux.
precice.write_data(fluxes_y)This entity is detected as a scalar entity by the adapter. This is a problem because the original function related to the flux is defined on a VectorFunctionSpace |
Contributor
Author
|
I just realized that OpenFOAM requires a scalar quantity. So the current approach is fine (at least for develop), if we don't want to change the OpenFOAM-side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I explain the bug here: 41b1a46#commitcomment-44959091