Skip to content

Update dev-docs with floc - #3006

Merged
bretg merged 4 commits into
masterfrom
jdwieland8282-patch-11
Jun 7, 2021
Merged

Update dev-docs with floc#3006
bretg merged 4 commits into
masterfrom
jdwieland8282-patch-11

Conversation

@jdwieland8282

Copy link
Copy Markdown
Member

Adding documentation for the FLoC user id module.

Adding documentation for the FLoC user id module.

@bretg bretg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few tweaks.

@smenzer smenzer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should the full sharedId token be shared in the docs someplace, though?

@patmmccann

patmmccann commented Jun 4, 2021 via email

Copy link
Copy Markdown
Collaborator

@bretg

bretg commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

should the full sharedId token be shared in the docs someplace, though?

Oh - I truncated the token because it blew out the table to the point where it was very awkward.

Take another look? Had to play around with getting that long of a string to appear without blowing out the page.

@smenzer smenzer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bretg

@bretg
bretg merged commit 5daab99 into master Jun 7, 2021
@bretg
bretg deleted the jdwieland8282-patch-11 branch June 7, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants