Adding userId to smartadserver.md - #2062
Merged
Merged
Conversation
Added the userId to the documentation.
smenzer
suggested changes
Jun 16, 2020
smenzer
left a comment
smenzer
left a comment
Collaborator
There was a problem hiding this comment.
userId docs should be at the top, not in the bid params table
this should be userIds rather than eids_supported Co-authored-by: Scott <smenzer@gmail.com>
This should not be with the bidder paramters and therefore should be moved out. Co-authored-by: Scott <smenzer@gmail.com>
1 task
jeanstemp
added
LGTM
Pending PBJS Release
and removed
question
Pending PBJS Release
labels
Contributor
|
@lowendavid This PR wound up with merge conflicts. Please fix them and I'll merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the userId to the documentation.
Minor cleanup