Skip to content

SharedId UserId submodule documentation - #2031

Merged
SKOCHERI merged 6 commits into
prebid:masterfrom
SKOCHERI:master
Jun 16, 2020
Merged

SharedId UserId submodule documentation#2031
SKOCHERI merged 6 commits into
prebid:masterfrom
SKOCHERI:master

Conversation

@SKOCHERI

@SKOCHERI SKOCHERI commented Jun 4, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@jdwieland8282
jdwieland8282 self-requested a review June 8, 2020 19:37
@jdwieland8282 jdwieland8282 self-assigned this Jun 8, 2020
@jdwieland8282

Copy link
Copy Markdown
Member

seems good to me

@jdwieland8282 jdwieland8282 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@jdwieland8282
jdwieland8282 requested a review from jlukas79 June 8, 2020 19:41
@bretg

bretg commented Jun 12, 2020

Copy link
Copy Markdown
Contributor

@jdwieland8282 - does this obsolete #1923 ?

@bretg bretg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add sharedId to the later sections of the document -- Bidder Adapter Implementation and Prebid Server Adapters.

@SKOCHERI

SKOCHERI commented Jun 12, 2020

Copy link
Copy Markdown
Contributor Author

Please add sharedId to the later sections of the document -- Bidder Adapter Implementation and Prebid Server Adapters.

@bretg Have updated it to add sharedId to later section

@SKOCHERI SKOCHERI closed this Jun 12, 2020
@SKOCHERI SKOCHERI reopened this Jun 12, 2020

@bretg bretg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - moving the section isn't at all what I meant. Please move it back to be alphabetical with the other userId modules.

Please read the sections I referred to.

  1. add an entry for sharedId into the table in the Bidder Adapter Implementation section
  2. add an en entry for sharedId into the user.ext.eids example in the Prebid Server Adapters section

@SKOCHERI

SKOCHERI commented Jun 12, 2020

Copy link
Copy Markdown
Contributor Author

@bretg Have updated the documentation
Have added the shared is details to Bidder Adapter Implementation and Prebid Server Adapters section
Have ordered the usedId modules and included sharedid in alphabetical order.
Have moved netID user id module above to order alphabetically. I hope that should be ok

@jdwieland8282

Copy link
Copy Markdown
Member

#2031 (comment)

@jdwieland8282 - does this obsolete #1923 ?

yes

@SKOCHERI
SKOCHERI merged commit a24d4bf into prebid:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants