New Adaptor: Glimpse Protocol - #2005
Merged
Merged
Conversation
tim-hm
commented
May 22, 2020
tim-hm
commented
Contributor
- Initial submission
- Author: Tim Holmes-Mitra tim@glimpseprotocol.io
* Initial submission * Author: Tim Holmes-Mitra <tim@glimpseprotocol.io>
1 task
bretg
suggested changes
May 23, 2020
bretg
left a comment
bretg
left a comment
Contributor
There was a problem hiding this comment.
- Please add an example and a type for your placementId parameter
- Please remove the 'table of contents' section -- this isn't long enough to need it
* Added placementId example and type
tim-hm
commented
May 29, 2020
tim-hm
left a comment
tim-hm
left a comment
Contributor
Author
There was a problem hiding this comment.
I've remove the TOC and added examples and type for placmeentId ... not sure how I missed them in the first place 🤦
Contributor
|
released with 3.23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.