Add waiting for secondary cache call in functional tests#163
Merged
Net-burst merged 3 commits intoMar 28, 2025
Merged
Conversation
osulzhenko
force-pushed
the
functional-tests/web-client-timeout-support
branch
from
March 27, 2025 16:01
64cc9a5 to
42a6ef2
Compare
osulzhenko
changed the base branch from
master
to
feature/web-client-timeout-support
March 27, 2025 16:09
osulzhenko
changed the title
marki1an
requested changes
Mar 28, 2025
| mockServerClient.retrieveRecordedRequests(getSecondaryCacheRequest(uuidKey)) | ||
| fun getSecondaryCacheRecordedRequests(uuidKey: String): Array<out HttpRequest>? { | ||
| val secondaryCacheRequest = getSecondaryCacheRequest(uuidKey) | ||
| waitUntil({ mockServerClient.retrieveRecordedRequests(secondaryCacheRequest)?.isNotEmpty() == true }) |
Contributor
There was a problem hiding this comment.
Can it be simplified?
waitUntil({ mockServerClient.retrieveRecordedRequests(secondaryCacheRequest)?.isNotEmpty() }) ?
Collaborator
Author
There was a problem hiding this comment.
Yeah, good call. I used a safer approach in case it returned null, but investigation shows that retrieveRecordedRequests can't return null. So, I updated it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.