Skip to content

Add functional tests for the new Apache Ignite feature#141

Merged
SerhiiNahornyi merged 3 commits into
apache-ignite-repofrom
functional-tests/apache-ignite-repo
Aug 6, 2024
Merged

Add functional tests for the new Apache Ignite feature#141
SerhiiNahornyi merged 3 commits into
apache-ignite-repofrom
functional-tests/apache-ignite-repo

Conversation

@osulzhenko

Copy link
Copy Markdown
Collaborator

No description provided.

@osulzhenko osulzhenko added tests functional Kotlin tests do not port labels Aug 5, 2024
@osulzhenko
osulzhenko requested a review from marki1an August 5, 2024 16:53
@osulzhenko osulzhenko self-assigned this Aug 5, 2024
"spring.ignite.port" to ApacheIgniteContainer.PORT.toString(),
"spring.ignite.host" to apacheIgniteHost,
"spring.ignite.cache-name" to cacheName,
"spring.ignite.timeout" to "300"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no timeout property in ignite


class ApacheIgniteCacheSpec : ShouldSpec({

should("throw an exception when cache record is absent in Apache ignite repository") {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I see we don't check expiration for keys and putIdAbsent logic

do we need?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All added, thanks for the comments

@SerhiiNahornyi
SerhiiNahornyi merged commit 17284dd into apache-ignite-repo Aug 6, 2024
@SerhiiNahornyi
SerhiiNahornyi deleted the functional-tests/apache-ignite-repo branch August 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not port tests functional Kotlin tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants